Skip to content

feat(app): slide sidebars open and closed - #192

Merged
Limdongcheng merged 1 commit into
mainfrom
feat/sidebar-slide
Nov 17, 2026
Merged

Limdongcheng merged 1 commit into
mainfrom
feat/sidebar-slide

Conversation

@Limdongcheng

Copy link
Copy Markdown
Collaborator

Summary

  • Slide the left and right sidebars open and closed over 200 ms with the existing chrome motion module. With Reduce motion on they show and hide at once.
  • While a sidebar slides, the workspace keeps its layout and the sidebar moves over it; the workspace lays out once when the slide ends. The sliding sidebar takes no input and blocks canvas gestures only where it is visible.
  • Stored sidebar widths change only while a sidebar is docked. Dragging a sidebar to the window edge still hides it at once.
  • The docked data sheet margin follows the sidebar layout instead of visibility.
  • Screenshot captures run with reduced motion.
  • Document the sidebar slide under Reduce motion in English and Chinese.

Validation

  • cargo pr-check
  • npm run build in docs/
  • New tests: widths stay fixed through a slide on either side and with both at once, reduced motion docks and hides on the same frame, later panels keep their auto ids, the sliding sidebar paints above the workspace from its first frame and owns the pointer over its visible part, and reversing a slide continues from where it is.

UI display logic

  • New or changed actions go through the command catalog (CommandId +
    describe) and are searchable in the command palette.
  • Hiding happens only at Ribbon-group level (dataset kind or width
    budget); transient states disable with a disabled_reason that says how
    to unblock.
  • No layout changes from background events; panels are never auto-closed.
  • New panels or empty regions show an empty state with a next step.
  • Docs updated in docs/ (English and zh-CN) for user-visible behavior.

@Limdongcheng
Limdongcheng merged commit e703a83 into main Nov 17, 2026
11 checks passed
@Limdongcheng
Limdongcheng deleted the feat/sidebar-slide branch November 17, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant